Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the padding of the buttons in the toolbars to zero #19018

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Set the padding of the buttons in the toolbars to zero #19018

merged 1 commit into from
Nov 10, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #19008.
In Firefox on mac, the default padding is set to 4px and with Firefox for iOS, it's set to 13px. The padding is useless for such buttons.

@calixteman
Set the padding of the buttons in the toolbars to zero
ca3b777 
It fixes mozilla#19008.
In Firefox on mac, the default padding is set to 4px and with Firefox for iOS, it's set to 13px.
The padding is useless for such buttons.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5470e2e7f9a2d7c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8c303a65d87bfe/output.txt

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/0f066ea4f4ddab9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c8c303a65d87bfe/output.txt

Total script time: 8.91 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0f066ea4f4ddab9/output.txt

Total script time: 0.98 mins

Published

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5470e2e7f9a2d7c/output.txt

Total script time: 20.18 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman calixteman merged commit 34e4c4f into mozilla:master Nov 10, 2024
7 checks passed
@calixteman calixteman deleted the issue19008 branch November 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Firefox on iOS doesn't display the PDFs properly.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus